[aerogear-dev] UPS unit tests

[Erik Jan de Wit]

Original test on my machine executes in 8.5 seconds the ‘new’ test in 15.115s

On 21 Jan,2015, at 16:59 , Erik Jan de Wit <edewit at redhat.com> wrote:

> This is using weld container, that is not a application container it doesn’t add a lot of execution time. It only enables CDI in tests.
> 
> On 21 Jan,2015, at 16:50 , Matthias Wessendorf <matzew at apache.org> wrote:
> 
>> I think the problem that I have with using Arquillian is the time of execution for these integration tests. It boots up a container and stuff and just makes the test execution take a very long time. We spoke about that in the past, and didn't do Aquillian due to that.
>> 
>> Not sure how others feel about it, but I'd prefer we dont boot a container inside our tests
>> 
>> On Wed, Jan 21, 2015 at 4:40 PM, Erik Jan de Wit <edewit at redhat.com> wrote:
>> Hi,
>> 
>> The database unit tests of the UPS contain a lot of setup code as setting up the database is done within the test method. I’m proposing to remove this ‘noise’ from the test and put it in a separate file. Another thing that is setting up the dao's, when we use arquillian weld container we can use injection in our tests to further reduce the boilerplate, have a look at an example:
>> 
>> https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df25e8e77d505f2844cf80ff5644/model/jpa/src/test/java/org/jboss/aerogear/unifiedpush/jpa/PushApplicationDaoTest.java
>> 
>> If you like I could do this for all these tests.
>> 
>> Cheers,
>> 	Erik Jan 
>> 
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> 
>> 
>> 
>> -- 
>> Matthias Wessendorf 
>> 
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> 
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20150121/532f597f/attachment.html