[arquillian-issues] [JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml

[arjan tijms (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13311105#comment-13311105 ] 

arjan tijms edited comment on ARQ-2051 at 10/24/16 6:03 PM:
------------------------------------------------------------

Hi Gerhard, thanks for your comments.

{quote}How are you downloading the liberty instance from Maven?{quote}

See for example https://github.com/javaee-samples/javaee7-samples/blob/master/pom.xml#L962

It's basically the same method that the other profiles for other servers use as well. 

{quote}Why is this more useful than that?{quote}

Packaging a copy of the server.xml file and then copying it over is quite a bit more work and less obvious than just setting a boolean. Ideally for the managed server variant this would even be the default (if I'm not mistaken TomEE does something like that).

{quote}I would think that if we start adding this, we will need further changes to support other features{quote}

Adding arbitrary other features (as in feature elements) would be rather trivial to support. The {{addFeatures}} method in the PR is already prepared for that. With that setting something like {{extraFeatures=usr:JaccFeature,JPA-1.0}} depending on conditions in the test setup is a bit higher level and more flexible than having to prepare a set of different full server.xml files for every combination.

As a followup issue and PR I wanted to do something like as suggested here: http://stackoverflow.com/questions/39259375/loading-data-source-for-datasourcedefinition-from-application-in-liberty#comment65882759_39259375

That is, adding a jar from from the archive (or project) that's being deployed as a shared library (<library> tag) and then let the application reference that via the existing {{commonLibraryRef}} support. Doing that all in various combinations with static server.xml files may be a bit too much.


was (Author: atijms):
Hi Gerhard, thanks for your comments.

{quote}How are you downloading the liberty instance from Maven?{quote}

See for example https://github.com/javaee-samples/javaee7-samples/blob/master/pom.xml#L962

It's basically the same method that the other profiles for other servers use as well. 

{quote}Why is this more useful than that?{quote}

Packaging a copy of the server.xml file and then copying it over is quite a bit more work and less obvious then just setting a boolean. Ideally for the managed server variant this would even be the default (if I'm not mistaken TomEE does something like that).

{quote}I would think that if we start adding this, we will need further changes to support other features{quote}

Adding arbitrary other features (as in feature elements) would be rather trivial to support. The {{addFeatures}} method in the PR is already prepared for that. With that setting something like {{extraFeatures=usr:JaccFeature,JPA-1.0}} depending on conditions in the test setup is a bit higher level and more flexible than having to prepare a set of different full server.xml files for every combination.

As a followup issue and PR I wanted to do something like as suggested here: http://stackoverflow.com/questions/39259375/loading-data-source-for-datasourcedefinition-from-application-in-liberty#comment65882759_39259375

That is, adding a jar from from the archive (or project) that's being deployed as a shared library (<library> tag) and then let the application reference that via the existing {{commonLibraryRef}} support. Doing that all in various combinations with static server.xml files may be a bit too much.

> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
>                 Key: ARQ-2051
>                 URL: https://issues.jboss.org/browse/ARQ-2051
>             Project: Arquillian
>          Issue Type: Feature Request
>          Components: WebSphere Containers
>    Affects Versions: was_1.0.0.Beta2
>            Reporter: arjan tijms
>            Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)