[arquillian-issues] [JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml

[Gerhard Poul (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13311636#comment-13311636 ] 

Gerhard Poul commented on ARQ-2051:
-----------------------------------

>From a conceptual point of view this is just moving stuff from server.xml into arquillian.xml and it removes the need to use the liberty:create-server module in this specific case.

I'm fine with adding this for people that prefer not to use the liberty:create-server module since the localConnector is a prerequisite for the arquillian container working, but I'd rather not duplicate functionality that is available in the liberty:create-server plugin like setting JVM parameters and others and just moving them into arquillian.xml without a good reason.

FYI: At this point in time our CI tests on wercker seem not to be working because they changed how they work with the docker containers. I'll need to fix that first before I can test and merge your PR.

> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
>                 Key: ARQ-2051
>                 URL: https://issues.jboss.org/browse/ARQ-2051
>             Project: Arquillian
>          Issue Type: Feature Request
>          Components: WebSphere Containers
>    Affects Versions: was_1.0.0.Beta2
>            Reporter: arjan tijms
>            Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)



--
This message was sent by Atlassian JIRA
(v7.2.2#72004)