[dna-issues] [JBoss JIRA] Commented: (DNA-246) org.jboss.dna.common.util.DateUtilTest failed with jdk1.5.0_16 and jdk1.6.0_10

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12437028#action_12437028 ] 

Randall Hauch commented on DNA-246:
-----------------------------------

The code in question is just reading and writing a date using the ISO format, and the problem is in the time zone conversion - that remarkably was performed during the extra hour due to the switch from daylight savings time.

I'm not convinced that we should do anything.  First, no repository should be running in DST (and hopefully will be running in UTC), so any error converting dates shouldn't be catastrophic.  Second, all of the date-time values in the repository will be JodaDateTime (newer versions of which may happen to have more recent timezone data than some JVMs), and even in the software we should probably be using DateTime values.  And third, since the error is due to out of date time zone data in the JVM, it seems like it's not something we can really address properly.

My vote is to to mark this issue as "will not fix".  Alternatively, we could probably remove this utility, which would require maybe removing or refactoring the StringUtil.readableString(...) method so that it's in dna-graph and part of the StringValueFactory.  The latter may actually clean up some of the somewhat duplicate code.

> org.jboss.dna.common.util.DateUtilTest failed with jdk1.5.0_16 and jdk1.6.0_10
> ------------------------------------------------------------------------------
>
>                 Key: DNA-246
>                 URL: https://jira.jboss.org/jira/browse/DNA-246
>             Project: DNA
>          Issue Type: Bug
>          Components: Common
>    Affects Versions: 0.3
>         Environment: Maven version: 2.0.9
> Java version: 1.5.0_16,  1.6.0_10
> OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"
> [user.timezone]=[Australia/Sydney]
>            Reporter: Sergiy Litsenko
>            Assignee: Randall Hauch
>             Fix For: 0.3
>
>
> Test set: org.jboss.dna.common.util.DateUtilTest
> -------------------------------------------------------------------------------
> Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.062 sec <<< FAILURE!
> shouldConvertDateToStringAndBack(org.jboss.dna.common.util.DateUtilTest)  Time elapsed: 0.016 sec  <<< FAILURE!
> java.lang.AssertionError: 
> Expected: is <Sun Feb 03 14:22:49 EST 2008>
>      got: <Sun Feb 03 13:22:49 EST 2008>
> 	at org.junit.Assert.assertThat(Assert.java:502)
> 	at org.junit.Assert.assertThat(Assert.java:492)
> 	at org.jboss.dna.common.util.DateUtilTest.shouldConvertDateToStringAndBack(DateUtilTest.java:57)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:585)
> 	at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
> 	at org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
> 	at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
> 	at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
> 	at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
> 	at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
> 	at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
> 	at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
> 	at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
> 	at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
> 	at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
> 	at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
> 	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
> 	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
> 	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
> 	at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:585)
> 	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:338)
> 	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:997)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira