[dna-issues] [JBoss JIRA] Updated: (DNA-338) Definitions That Allow SNS Are Not Used For Nodes Without SNS

Wed Apr 1 12:10:22 EDT 2009

     [ https://jira.jboss.org/jira/browse/DNA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randall Hauch updated DNA-338:
------------------------------

    Attachment: DNA-338-the-fix.patch

I believe the reason the patch did not include an effective change was that Brian had multiple changes brewing in his workspace (see DNA-339).  The actual correction for this behavior was buried in RepositoryNodeTypeManager.findChildNodeDefinition(...), where the boolean determining whether SNS were required was computed incorrectly.  See the attached "DNA-338-the-fix.patch", which was applied.

> Definitions That Allow SNS Are Not Used For Nodes Without SNS
> -------------------------------------------------------------
>
>                 Key: DNA-338
>                 URL: https://jira.jboss.org/jira/browse/DNA-338
>             Project: DNA
>          Issue Type: Bug
>          Components: Graph
>    Affects Versions: 0.4
>            Reporter: Brian Carothers
>            Assignee: Randall Hauch
>             Fix For: 0.4
>
>         Attachments: DNA-338-the-fix.patch, DNA-338.patch
>
>
> Currently, RepositoryNodeTypeManager.findChildNodeDefinition will not consider definitions that allow SNS if the child node does not require SNS.  That is, if a new child node is added (and, hence, does not yet have any SNS) to a parent node that would only allow the child node with SNS (i.e., there's not definition that supports the child without SNS), findChildNodeDefinition returns null.
> Section 6.7.7 (regarding child node definitions) in the JCR 1.0 spec reads (in part) that the child node definition indicates "[w]hether this child node can have same-name siblings, meaning that the parent node can have more than one child node of this name."  I may be reading too much into the use of the word "can" instead of "must", but I think that SNS definitions allow for a single node, just like multi-valued property definitions support a multi-valued property that happens to have one value.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira