[dna-issues] [JBoss JIRA] Commented: (DNA-339) JCR Type Registration and Unregistration

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12460047#action_12460047 ] 

Randall Hauch commented on DNA-339:
-----------------------------------

I like the approach of using templates (ala 283).  Is there a way to change the NodeTypeSource-approach to use the new registration mechanism?  Seems like that might clean up things quite a bit.

I also do like where you are going with refactoring of findPropertyDefinition to use Predicates.  However, I'm not convinced it's better.  One goal I had with the old design was that the logic was very obvious and "in your face" (not masked by a lot of method calls), and I deemed this as more beneficial than the ugliness of the duplication.  So while the new approach gets rid of the duplication, it doesn't really keep the "in your face" logic.  Plus, the new approach doesn't reduce the number of lines (385 new vs 373 old).  Besides, I'd prefer for this change to be pulled out into a different patch (or even a different issue).

Also, considering the size of the change to support registration and unregistration, would it be better to not address thread-safety in the same patch?  Also, although using a thread-safe container would be beneficial, we made need to use an explicit ReadWriteLock if the thread-safe container doesn't offer the required level of atomicity.

Requiring users to oder the types to be registered is a perfectly valid assumption, I think.  At least for now, since it'd likely keep the implementation much more simplistic.

One thing we're going to have to address is that we can't update existing JcrNodeType objects.  So, if a supertype is changed (re-registered), we really need to rebuild all of the node types that extend it.  Unfortunately this is the only way to truly have immutable objects.

> JCR Type Registration and Unregistration
> ----------------------------------------
>
>                 Key: DNA-339
>                 URL: https://jira.jboss.org/jira/browse/DNA-339
>             Project: DNA
>          Issue Type: Feature Request
>          Components: JCR
>    Affects Versions: 0.4
>            Reporter: Brian Carothers
>         Attachments: DNA-339_RFC.patch
>
>
> It would be useful for DNA to support type registration and unregistration (a la JSR 2.0 (draft) spec section 6.10).  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira