[dna-issues] [JBoss JIRA] Commented: (DNA-541) Locking Implementation Does Not Support Timeouts

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12498616#action_12498616 ] 

Randall Hauch commented on DNA-541:
-----------------------------------

Nice job!  The patch looks good, tho I have a few comments:

1) The ScheduledExecutorService should be shutdown when the JcrEngine is shutdown, so JcrEngine needs to override the DnaEngine.shutdown() method.
2) The new JcrRepository.cleanUpLocks() method should make its copy of the JcrSession objects (or their IDs) in a synchronized block.  (Helping identify when the methods/fields can be used w/r/t concurrency is one reason I try to put the JCIP annotations on the methods and fields).
3) The ExecutionContext that was newly added to WorkspaceLockManager doesn't appear to be used (or certainly is not used nearly as much as their session's)

> Locking Implementation Does Not Support Timeouts
> ------------------------------------------------
>
>                 Key: DNA-541
>                 URL: https://jira.jboss.org/jira/browse/DNA-541
>             Project: DNA
>          Issue Type: Bug
>          Components: JCR
>            Reporter: Brian Carothers
>            Assignee: Brian Carothers
>             Fix For: 0.7
>
>         Attachments: DNA-541_admin_unlock.patch, DNA-541_lock_timeout.patch
>
>
> The locking implementation does not provide a means of expiring stale or old locks (other than having the original owner unlock them).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira