[dna-issues] [JBoss JIRA] Commented: (DNA-541) Locking Implementation Does Not Support Timeouts

[Brian Carothers (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12498636#action_12498636 ] 

Brian Carothers commented on DNA-541:
-------------------------------------

Responding point-by-point to the previous comment:

1.  Good call.  I've also added startup and awaitTermination to clean up the start-stop behavior with the new service.
2.  Good call.  Is it sufficient to wrap the three accesses to the activeSessions map in synchonized (this.activeSessions) { ... }?  If not, I promise to go buy a copy of JCIP and read it over Xmas break.
3.  Yeah, I'll add a comment on that one.  The WLM's execution context is used only when performing actions outside the scope of the session.  In general, I'm still trying to use the relevant session's context in case we ever start leveraging SSO more fully and use the session's JAAS subject and privileges to broker access to underlying repositories (which some incarnation of the jcr:system branch may rely on).  Let me know if you want me to standardize on using one context or the other.

Thanks for the great feedback!

> Locking Implementation Does Not Support Timeouts
> ------------------------------------------------
>
>                 Key: DNA-541
>                 URL: https://jira.jboss.org/jira/browse/DNA-541
>             Project: DNA
>          Issue Type: Bug
>          Components: JCR
>            Reporter: Brian Carothers
>            Assignee: Brian Carothers
>             Fix For: 0.7
>
>         Attachments: DNA-541_admin_unlock.patch, DNA-541_lock_timeout.patch
>
>
> The locking implementation does not provide a means of expiring stale or old locks (other than having the original owner unlock them).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira