[dna-issues] [JBoss JIRA] Commented: (DNA-443) Java sequencer is not saving content correctly

Brian Carothers (JIRA) jira-events at lists.jboss.org
Fri Jun 5 16:13:56 EDT 2009


    [ https://jira.jboss.org/jira/browse/DNA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12470868#action_12470868 ] 

Brian Carothers commented on DNA-443:
-------------------------------------

The problem seems to be around line 151 of InMemoryRequestProcessor.  This trap is hitting:

        InMemoryNode parentNode = workspace.getNode(parent);
        if (parentNode == null) {
            Path lowestExisting = workspace.getLowestExistingPath(parent);
            request.setError(new PathNotFoundException(request.under(), lowestExisting,
                                                       GraphI18n.inMemoryNodeDoesNotExist.text(parent)));
            return;
        }

The parentNode seems to be null because the sequence of create node requests generated by the sequencer starts off like so:

 dna:compilationUnit
 dna:compilationUnit/dna:import/dna:importDeclaration/dna:importOnDemand/dna:typeImportOnDemandDeclaration

It seems as though the problem is that the request processor is trying to create dna:typeImportOnDemandDeclaration before dna:compilationUnit/dna:import exists.  

I see this as a problem with the sequencer.  We could make the request processors smart enough to build any missing nodes, but the interpolated nodes wouldn't have useful properties like jcr:primaryType, so I think that approach would just defer the problem.  

I'll poke around the sequencer and see if I can fix this.





> Java sequencer is not saving content correctly
> ----------------------------------------------
>
>                 Key: DNA-443
>                 URL: https://jira.jboss.org/jira/browse/DNA-443
>             Project: DNA
>          Issue Type: Bug
>          Components: Examples, Sequencers
>    Affects Versions: 0.4
>            Reporter: Randall Hauch
>             Fix For: 0.6
>
>
> The Java sequencer doesn't appear to be sequencing the Java source code and saving it correctly.  The SequencingClientTest.shouldUploadAndSequenceJavaSourceFile() fails and has been temporarily ignored.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the dna-issues mailing list