[dna-issues] [JBoss JIRA] Resolved: (DNA-443) Java sequencer is not saving content correctly

[Brian Carothers (JIRA)]

     [ https://jira.jboss.org/jira/browse/DNA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Carothers resolved DNA-443.
---------------------------------

    Fix Version/s: 0.5
                       (was: 0.6)
       Resolution: Done
         Assignee: Brian Carothers


Well, the initial guess was in the ballpark but not correct.

Part of the StreamSequencerAdapter code (the buildPathTo part) was operating directly against the graph for reads and writes.  The other part (saveOutput) was operating against a destination that happened to be a batch.  The batch doesn't save until all of the processing for the output of a particular sequencer is complete, leading to some race conditions between the two parts of the code.  The batch is there to support a all-or-nothing save semantics for the output of a particular sequencer.

The most correct solution is to switch all of the code to use a batch, but this creates some challenges.  For one thing, the batch doesn't support the concept of createIfMissing semantics or reads of any sort.  I think that we would have to keep some sort of internal graph of nodes added to the batch while processing the sequencer output and check against that as well as the nodes in the graph.

My workaround for now is to make all of the operations in StreamSequencerAdapter work directly against the graph.  We can always revisit this in 0.6.

> Java sequencer is not saving content correctly
> ----------------------------------------------
>
>                 Key: DNA-443
>                 URL: https://jira.jboss.org/jira/browse/DNA-443
>             Project: DNA
>          Issue Type: Bug
>          Components: Examples, Sequencers
>    Affects Versions: 0.4
>            Reporter: Randall Hauch
>            Assignee: Brian Carothers
>             Fix For: 0.5
>
>
> The Java sequencer doesn't appear to be sequencing the Java source code and saving it correctly.  The SequencingClientTest.shouldUploadAndSequenceJavaSourceFile() fails and has been temporarily ignored.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira