[gatein-dev] GateIn parent pom

[aheritier at gmail.com]

On Thu, Feb 24, 2011 at 6:01 PM, Thomas Heute <theute at redhat.com> wrote:

> Now that our Maven expert is back :)
>
He he :-)
Effectively, I'm back and in VN this time :-D


> I plan to do some update in our GateIn parent, the diff below is pretty
> much self explanatory, but here are the points:
>
>    - Removed repositories + pluginRepositories definitions, it's supposed
> to be a best practice, correct me if I'm wrong (But will require people to
> have those defined in their local installation or we add them in the root
> pom.xml instead)
>
+10000 : It will also increse your build time as more you have repositories
in your settings/poms, more maven will loose time to try missing deps or
snapshots updates in them
http://www.sonatype.com/people/2009/02/why-putting-repositories-in-your-poms-is-a-bad-idea/
In theory (sorry the wiki is down I hope it is the good link:( ) you should
follow this doc and ask gatein community to do it to contribute :
http://community.jboss.org/wiki/mavensettings


>    - Added JDK 6 as min version
>

Instead of setting jdk.min.version you should better set
maven.compiler.source and maven.compiler.target to 1.6 if this is what is
targeted now
You can see them here :
http://anonsvn.jboss.org/repos/maven/poms/jboss-parent-pom/tags/jboss-parent-5/pom.xml


>    - Removed the Maven release plugin parameters, they are only meaningful
> for GateIn Portal and not for the components. Plus we added new profiles for
> new packaging (AS6, AS6, Tomcat 6, Tomcat 7, Jetty). This would be added in
> the root pom of GateIn Portal
>

I agree


>    - Removed org.codehaus.mojo:jboss-packaging-maven-plugin declaration, I
> think it's only to build SAR packages. And SAR packages are only used for a
> component or 2.
>
>
+1


>
> Arnaud, what do you think ?
>

It's a little bit out of your scope but we should either think to update
plugins versions defined in jboss parent pom (we could see with Paul Gier)
or override these properties in GateIn. A lot of plugins were updated to
take care of Maven 3 and to have a better behavior in // builds for exemple.
You can easily find the list of latest versions of plugins with : mvn
versions:display-plugin-updates<http://mojo.codehaus.org/versions-maven-plugin/display-plugin-updates-mojo.html>
http://mojo.codehaus.org/versions-maven-plugin/examples/display-plugin-updates.html

I may do it but it won't be I think before my travel back from VN (in 10
days)

If you have few time it is easy: You update these versions in gatein
parent-pom, you install it, you update locally all your gatein projects to
use this SNAPSHOT and you test a full build.

cheers

arnaud



>
> Thomas.
>
>
>
>
> Here is the diff:
>
> Index: pom.xml
> ===================================================================
> --- pom.xml    (revision 5914)
> +++ pom.xml    (working copy)
> @@ -14,7 +14,7 @@
>
> <groupId>org.gatein</groupId>
> <artifactId>gatein-parent</artifactId>
> - <version>1.0.3-GA-SNAPSHOT</version>
> + <version>1.1.0-GA-SNAPSHOT</version>
> <packaging>pom</packaging>
>
> <scm>
> @@ -40,12 +40,11 @@
>
> <!-- maven-enforcer-plugin -->
> <maven.min.version>2.2.1</maven.min.version>
>
> + <jdk.min.version>1.6</jdk.min.version>
> +
> <!-- maven-release-plugin -->
> <autoVersionSubmodules>true</autoVersionSubmodules>
>
> - <!-- maven-release-plugin -->
> - <arguments>-Prelease,pkg-tomcat,pkg-jbossas -DskipTests</arguments>
> -
> <!-- cf http://jira.codehaus.org/browse/MRELEASE-3 -->
> <preparationGoals>clean install</preparationGoals>
> </properties>
> @@ -60,11 +59,6 @@
>
> <!-- Plugins are sorted by shortname : clean, deploy, ... -->
> <plugins>
> <plugin>
> - <groupId>org.codehaus.mojo</groupId>
> - <artifactId>jboss-packaging-maven-plugin</artifactId>
> - <version>2.0-beta-1</version>
> - </plugin>
> - <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> @@ -167,43 +161,6 @@
>
> </profiles>
>
> <!-- **************** -->
> - <!-- Repositiories    -->
> - <!-- **************** -->
> - <repositories>
> - <repository>
> - <id>jboss-public-repository-group</id>
> - <name>JBoss Public Maven Repository Group</name>
> - <url>https://repository.jboss.org/nexus/content/groups/public/</url>
> - <layout>default</layout>
> - <releases>
> - <enabled>true</enabled>
> - <updatePolicy>never</updatePolicy>
> - </releases>
> - <snapshots>
> - <enabled>true</enabled>
> - <updatePolicy>never</updatePolicy>
> - </snapshots>
> - </repository>
> - </repositories>
> -
> - <pluginRepositories>
> - <pluginRepository>
> - <id>jboss-public-repository-group</id>
> - <name>JBoss Public Maven Repository Group</name>
> - <url>https://repository.jboss.org/nexus/content/groups/public/</url>
> - <layout>default</layout>
> - <releases>
> - <enabled>true</enabled>
> - <updatePolicy>never</updatePolicy>
> - </releases>
> - <snapshots>
> - <enabled>true</enabled>
> - <updatePolicy>never</updatePolicy>
> - </snapshots>
> - </pluginRepository>
> - </pluginRepositories>
> -
> - <!-- **************** -->
> <!-- Reporting        -->
> <!-- **************** -->
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/gatein-dev/attachments/20110224/aa4aa6d6/attachment.html