[hibernate-commits] [hibernate/hibernate-search] c333dd: HSEARCH-2868 Fix typos (missing "final" keywords)

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: c333dd609c3d9c3a1f5de14b7749cbbfced2482a
      https://github.com/hibernate/hibernate-search/commit/c333dd609c3d9c3a1f5de14b7749cbbfced2482a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/CollectionUpdateEventTest.java

  Log Message:
  -----------
  HSEARCH-2868 Fix typos (missing "final" keywords)


  Commit: a8b0c7ba85d7b2a72c588d8eeee1641261a4515f
      https://github.com/hibernate/hibernate-search/commit/a8b0c7ba85d7b2a72c588d8eeee1641261a4515f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M orm/src/main/java/org/hibernate/search/event/impl/FullTextIndexEventListener.java

  Log Message:
  -----------
  HSEARCH-2868 Do not ignore updates on un-initialized collections in FullTextIndexEventListener

Some collections, such as the reverse side of an unordered,
duplicate-allowing association, may not be initialized upon adds, and in
those cases we may still want to trigger reindexing, provided the
collection is used to generate an index field.

This fixes HSEARCH-782 in a (hopefully) more correct way. The original
fix added an "if" skipping reindexing when a collection being updated
wasn't initialized, but this is incorrect, as the collection may still
affect the indexed form of the entity (the collection may not be
initialized but still have pending updates in an internal queue).
The new fix removes this skipping, and simply does not add ContainedIn
collection roles to the list of collection roles used when generating
documents from an entity.


  Commit: b03b5af32e55e6383efa89d26311f53c7cb92a52
      https://github.com/hibernate/hibernate-search/commit/b03b5af32e55e6383efa89d26311f53c7cb92a52
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    A orm/src/test/java/org/hibernate/search/test/engine/optimizations/BridgedReverseBagCollectionUpdateEventTest.java

  Log Message:
  -----------
  HSEARCH-2868 Test that adding elements to a reverse persistent bag triggers reindexing

Or, more acurately, test that adding elements to a persistent bag representing the
reverse side of an association (which shouldn't initialize the bag) will trigger
reindexing if that bag is used in a field.


Compare: https://github.com/hibernate/hibernate-search/compare/f41399e54765...b03b5af32e55