[hibernate-commits] [hibernate/hibernate-search] 1487cb: HSEARCH-2868 Fix typos (missing "final" keywords)

[GitHub]

  Branch: refs/heads/5.6
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 1487cb693576b436d491d22f07c4f6cfdd446d73
      https://github.com/hibernate/hibernate-search/commit/1487cb693576b436d491d22f07c4f6cfdd446d73
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/CollectionUpdateEventTest.java

  Log Message:
  -----------
  HSEARCH-2868 Fix typos (missing "final" keywords)


  Commit: ae5a70f6959a5956e1d44b62b0ff8a734a1c24ac
      https://github.com/hibernate/hibernate-search/commit/ae5a70f6959a5956e1d44b62b0ff8a734a1c24ac
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M orm/src/main/java/org/hibernate/search/event/impl/FullTextIndexEventListener.java

  Log Message:
  -----------
  HSEARCH-2868 Do not ignore updates on un-initialized collections in FullTextIndexEventListener

Some collections, such as the reverse side of an unordered,
duplicate-allowing association, may not be initialized upon adds, and in
those cases we may still want to trigger reindexing, provided the
collection is used to generate an index field.

This fixes HSEARCH-782 in a (hopefully) more correct way. The original
fix added an "if" skipping reindexing when a collection being updated
wasn't initialized, but this is incorrect, as the collection may still
affect the indexed form of the entity (the collection may not be
initialized but still have pending updates in an internal queue).
The new fix removes this skipping, and simply does not add ContainedIn
collection roles to the list of collection roles used when generating
documents from an entity.


  Commit: b509b47975e73e4c4abc674c143247306433fe34
      https://github.com/hibernate/hibernate-search/commit/b509b47975e73e4c4abc674c143247306433fe34
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    A orm/src/test/java/org/hibernate/search/test/engine/optimizations/BridgedReverseBagCollectionUpdateEventTest.java

  Log Message:
  -----------
  HSEARCH-2868 Test that adding elements to a reverse persistent bag triggers reindexing

Or, more acurately, test that adding elements to a persistent bag representing the
reverse side of an association (which shouldn't initialize the bag) will trigger
reindexing if that bag is used in a field.


  Commit: 3bc9c2ae9b5678389d1475402f15bba0960e7009
      https://github.com/hibernate/hibernate-search/commit/3bc9c2ae9b5678389d1475402f15bba0960e7009
  Author: Sanne Grinovero <sanne at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/BridgedReverseBagCollectionUpdateEventTest.java

  Log Message:
  -----------
  HSEARCH-2868 Modify backport to be compatible with Hibernate ORM 5.1


Compare: https://github.com/hibernate/hibernate-search/compare/98a4e7a1b8cd...3bc9c2ae9b56