[hibernate-commits] [hibernate/hibernate-search] 4b76ab: HSEARCH-2868 Fix typos (missing "final" keywords)

[GitHub]

  Branch: refs/heads/5.7
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 4b76ab6a8926a6714a7d00f679a0ccb9aaf5e799
      https://github.com/hibernate/hibernate-search/commit/4b76ab6a8926a6714a7d00f679a0ccb9aaf5e799
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/CollectionUpdateEventTest.java

  Log Message:
  -----------
  HSEARCH-2868 Fix typos (missing "final" keywords)


  Commit: 02fddaf81deee536a2015149042b8e2b31fffeca
      https://github.com/hibernate/hibernate-search/commit/02fddaf81deee536a2015149042b8e2b31fffeca
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M orm/src/main/java/org/hibernate/search/event/impl/FullTextIndexEventListener.java

  Log Message:
  -----------
  HSEARCH-2868 Do not ignore updates on un-initialized collections in FullTextIndexEventListener

Some collections, such as the reverse side of an unordered,
duplicate-allowing association, may not be initialized upon adds, and in
those cases we may still want to trigger reindexing, provided the
collection is used to generate an index field.

This fixes HSEARCH-782 in a (hopefully) more correct way. The original
fix added an "if" skipping reindexing when a collection being updated
wasn't initialized, but this is incorrect, as the collection may still
affect the indexed form of the entity (the collection may not be
initialized but still have pending updates in an internal queue).
The new fix removes this skipping, and simply does not add ContainedIn
collection roles to the list of collection roles used when generating
documents from an entity.


  Commit: c5c9b0af6d2b0c8cfb7bf374775adef426259703
      https://github.com/hibernate/hibernate-search/commit/c5c9b0af6d2b0c8cfb7bf374775adef426259703
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    A orm/src/test/java/org/hibernate/search/test/engine/optimizations/BridgedReverseBagCollectionUpdateEventTest.java

  Log Message:
  -----------
  HSEARCH-2868 Test that adding elements to a reverse persistent bag triggers reindexing

Or, more acurately, test that adding elements to a persistent bag representing the
reverse side of an association (which shouldn't initialize the bag) will trigger
reindexing if that bag is used in a field.


Compare: https://github.com/hibernate/hibernate-search/compare/9d72c31943f1...c5c9b0af6d2b