[hibernate-commits] [hibernate/hibernate-orm] 3759f7: HHH-12786 Properly indent the Bytebuddy DSL

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: 3759f776ab85fb7e4a8b7860810c6279afe6ec4a
      https://github.com/hibernate/hibernate-orm/commit/3759f776ab85fb7e4a8b7860810c6279afe6ec4a
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BytecodeProviderImpl.java
    M hibernate-core/src/main/java/org/hibernate/proxy/pojo/bytebuddy/ByteBuddyProxyFactory.java

  Log Message:
  -----------
  HHH-12786 Properly indent the Bytebuddy DSL

It helps to understand what exactly these calls do.


  Commit: ed53fd534615e5c75a3937f6947d1387e57d7b91
      https://github.com/hibernate/hibernate-orm/commit/ed53fd534615e5c75a3937f6947d1387e57d7b91
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/Adult.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/ComponentBasicProxyTest.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/Person.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/PersonId.java

  Log Message:
  -----------
  HHH-12786 Allow to call methods when the interceptor is not set yet

Typically, if the constructor calls instrumented methods, the
interceptor is not defined yet and we get a NPE.


  Commit: f722db367ec3631a269188ba8e5952a3d6ef5f02
      https://github.com/hibernate/hibernate-orm/commit/f722db367ec3631a269188ba8e5952a3d6ef5f02
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java

  Log Message:
  -----------
  HHH-12786 Only define the default constructor

We don't need the others, better not create them in the proxy.


  Commit: 208e789bb107503a5df7a62531570ececaa4c0ed
      https://github.com/hibernate/hibernate-orm/commit/208e789bb107503a5df7a62531570ececaa4c0ed
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/PassThroughInterceptor.java
    A hibernate-core/src/test/java/org/hibernate/test/proxy/bytebuddy/ByteBuddyBasicProxyFactoryTest.java

  Log Message:
  -----------
  HHH-12786 Improve the basic proxy interceptor

Apart from cosmetic changes, we were testing in the equals() method that the
instance == the proxied object which will always be true.

We should use the argument of the equals() method instead to do the
comparison.

And we can do the comparison on the instance, instead of requiring
passing the proxiedObject into the interceptor.


Compare: https://github.com/hibernate/hibernate-orm/compare/6e85dd82f326...208e789bb107
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.