[hibernate-commits] [hibernate/hibernate-orm] 297031: HHH-12786 Properly indent the Bytebuddy DSL

[GitHub]

  Branch: refs/heads/5.3
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: 297031319d96bf7622ba4ec82df5299af921c3fa
      https://github.com/hibernate/hibernate-orm/commit/297031319d96bf7622ba4ec82df5299af921c3fa
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BytecodeProviderImpl.java
    M hibernate-core/src/main/java/org/hibernate/proxy/pojo/bytebuddy/ByteBuddyProxyFactory.java

  Log Message:
  -----------
  HHH-12786 Properly indent the Bytebuddy DSL

It helps to understand what exactly these calls do.


  Commit: 0fda6be86e385658ddff76245a29631840e77da4
      https://github.com/hibernate/hibernate-orm/commit/0fda6be86e385658ddff76245a29631840e77da4
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/Adult.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/ComponentBasicProxyTest.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/Person.java
    A hibernate-core/src/test/java/org/hibernate/test/component/proxy/PersonId.java

  Log Message:
  -----------
  HHH-12786 Allow to call methods when the interceptor is not set yet

Typically, if the constructor calls instrumented methods, the
interceptor is not defined yet and we get a NPE.


  Commit: 67698b8bdbbafe8fb4b11c1372dbe3a2b17a9b80
      https://github.com/hibernate/hibernate-orm/commit/67698b8bdbbafe8fb4b11c1372dbe3a2b17a9b80
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java

  Log Message:
  -----------
  HHH-12786 Only define the default constructor

We don't need the others, better not create them in the proxy.


  Commit: 1688c3ff8d735b4bcdfeed0951e4cd571f5f5025
      https://github.com/hibernate/hibernate-orm/commit/1688c3ff8d735b4bcdfeed0951e4cd571f5f5025
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/BasicProxyFactoryImpl.java
    M hibernate-core/src/main/java/org/hibernate/bytecode/internal/bytebuddy/PassThroughInterceptor.java
    A hibernate-core/src/test/java/org/hibernate/test/proxy/bytebuddy/ByteBuddyBasicProxyFactoryTest.java

  Log Message:
  -----------
  HHH-12786 Improve the basic proxy interceptor

Apart from cosmetic changes, we were testing in the equals() method that the
instance == the proxied object which will always be true.

We should use the argument of the equals() method instead to do the
comparison.

And we can do the comparison on the instance, instead of requiring
passing the proxiedObject into the interceptor.


Compare: https://github.com/hibernate/hibernate-orm/compare/0818195cea27...1688c3ff8d73
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.