[hibernate-commits] [hibernate/hibernate-orm] c3c322: HHH-12718 - Entity changes in @PreUpdate callback ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: c3c322d91b6fbbafc69b1364de8603927b046f43
      https://github.com/hibernate/hibernate-orm/commit/c3c322d91b6fbbafc69b1364de8603927b046f43
  Author: Ulrich Bestfleisch <ulrich.bestfleisch at sap.com>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java
    A hibernate-core/src/test/java/org/hibernate/jpa/test/callbacks/PreUpdateBytecodeEnhancementTest.java
    A hibernate-core/src/test/java/org/hibernate/jpa/test/callbacks/PreUpdateCustomEntityDirtinessStrategyTest.java
    A hibernate-core/src/test/java/org/hibernate/jpa/test/callbacks/PreUpdateDirtyCheckingInterceptorTest.java

  Log Message:
  -----------
  HHH-12718 - Entity changes in @PreUpdate callback are not persisted when lazy loading is active for more than one field


  Commit: a9f743069b5e38e59645bf291c816f77d99018a1
      https://github.com/hibernate/hibernate-orm/commit/a9f743069b5e38e59645bf291c816f77d99018a1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/test/java/org/hibernate/test/dirtiness/CustomDirtinessStrategyTest.java

  Log Message:
  -----------
  HHH-12718 Test that dirtiness strategies are invoked a second time after a flush interceptor changes the entity state

Bytecode enhancement is harder to test, so I didn't add a test for that,
but since bytecode enhancement dirty checking is called exactly at the
same place, if one works, the other should, too.


  Commit: 74aa03881ad2a031d25ab1c5f663c32c8d08ec3a
      https://github.com/hibernate/hibernate-orm/commit/74aa03881ad2a031d25ab1c5f663c32c8d08ec3a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java
    M hibernate-core/src/test/java/org/hibernate/test/dirtiness/CustomDirtinessStrategyTest.java

  Log Message:
  -----------
  HHH-12718 Compute dirtiness using whatever method is appropriate after a flush event interception

We used to have a simpler version of the dirtyCheck() method after an
interception, but that's not enough.


  Commit: 7134e8b968937f2fa0c58b47ade68d9b6790955b
      https://github.com/hibernate/hibernate-orm/commit/7134e8b968937f2fa0c58b47ade68d9b6790955b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java

  Log Message:
  -----------
  HHH-12718 Avoid double negations in DefaultFlushEntityEventListener#dirtyCheck


  Commit: 92f475888962b563c4a0fb716f74ad54d08dec3a
      https://github.com/hibernate/hibernate-orm/commit/92f475888962b563c4a0fb716f74ad54d08dec3a
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java

  Log Message:
  -----------
  HHH-12718 Add a comment about the true meaning of interceptorHandledDirtyCheck


Compare: https://github.com/hibernate/hibernate-orm/compare/523b29af0481...92f475888962
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.