[hibernate-commits] [hibernate/hibernate-orm] a180ca: HHH-12718 - Entity changes in @PreUpdate callback ...

[GitHub]

  Branch: refs/heads/5.3
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: a180caecd68dbe992af2f7c3c65916ffb6f4d23a
      https://github.com/hibernate/hibernate-orm/commit/a180caecd68dbe992af2f7c3c65916ffb6f4d23a
  Author: Ulrich Bestfleisch <ulrich.bestfleisch at sap.com>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java
    A hibernate-core/src/test/java/org/hibernate/jpa/test/callbacks/PreUpdateBytecodeEnhancementTest.java
    A hibernate-core/src/test/java/org/hibernate/jpa/test/callbacks/PreUpdateCustomEntityDirtinessStrategyTest.java
    A hibernate-core/src/test/java/org/hibernate/jpa/test/callbacks/PreUpdateDirtyCheckingInterceptorTest.java

  Log Message:
  -----------
  HHH-12718 - Entity changes in @PreUpdate callback are not persisted when lazy loading is active for more than one field


  Commit: 47107e3e889c96467a7f0fd7fc7179f182b4a91c
      https://github.com/hibernate/hibernate-orm/commit/47107e3e889c96467a7f0fd7fc7179f182b4a91c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/test/java/org/hibernate/test/dirtiness/CustomDirtinessStrategyTest.java

  Log Message:
  -----------
  HHH-12718 Test that dirtiness strategies are invoked a second time after a flush interceptor changes the entity state

Bytecode enhancement is harder to test, so I didn't add a test for that,
but since bytecode enhancement dirty checking is called exactly at the
same place, if one works, the other should, too.


  Commit: e53e0ef790fee06347dca22fb7b03a94a335fe93
      https://github.com/hibernate/hibernate-orm/commit/e53e0ef790fee06347dca22fb7b03a94a335fe93
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java
    M hibernate-core/src/test/java/org/hibernate/test/dirtiness/CustomDirtinessStrategyTest.java

  Log Message:
  -----------
  HHH-12718 Compute dirtiness using whatever method is appropriate after a flush event interception

We used to have a simpler version of the dirtyCheck() method after an
interception, but that's not enough.


  Commit: da2d986efbac0ae8b2fd483fc031061f8980677c
      https://github.com/hibernate/hibernate-orm/commit/da2d986efbac0ae8b2fd483fc031061f8980677c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java

  Log Message:
  -----------
  HHH-12718 Avoid double negations in DefaultFlushEntityEventListener#dirtyCheck


  Commit: dde8744ca3306c5b55f4970c12ef64d78fbff079
      https://github.com/hibernate/hibernate-orm/commit/dde8744ca3306c5b55f4970c12ef64d78fbff079
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java

  Log Message:
  -----------
  HHH-12718 Add a comment about the true meaning of interceptorHandledDirtyCheck


Compare: https://github.com/hibernate/hibernate-orm/compare/0b92eb528df1...dde8744ca330
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.