[hibernate-dev] [OGM] Checkstyle rule failing in Windows

[Davide D'Alto]

Awesome,
Thanks


On Thu, Apr 25, 2013 at 12:51 PM, Guillaume SCHEIBEL <
guillaume.scheibel at gmail.com> wrote:

> I ran both "mvn clean compile" and "mvn checkstyle:checkstyle" on my
> windows laptop and got 2 "build success".
>
> Guillaume
>
>
> 2013/4/25 Davide D'Alto <davide at hibernate.org>
>
>> Thanks you Gunnar,
>>
>> Davide
>>
>>
>> On Thu, Apr 25, 2013 at 12:07 PM, Gunnar Morling <gunnar at hibernate.org
>> >wrote:
>>
>> >
>> > Am 25.04.2013 12:34 schrieb "Davide D'Alto" <davide at hibernate.org>:
>> >
>> > >
>> > > Thanks Guillaume,
>> > > are you going to test it on Windows isn't?
>> > >
>> > > We still need a volunteer with a Mac.
>> >
>> > I can do that.
>> >
>> > --Gunnar
>> >
>> > >
>> > >
>> > > On Thu, Apr 25, 2013 at 11:10 AM, Guillaume SCHEIBEL <
>> > > guillaume.scheibel at gmail.com> wrote:
>> > >
>> > > > hello,
>> > > >
>> > > > I'm checking and keep you up to date.
>> > > >
>> > > > Guillaume
>> > > >
>> > > >
>> > > > 2013/4/25 Davide D'Alto <davide at hibernate.org>
>> > > >
>> > > >> Hi,
>> > > >> we have a problem with one of the rules in checkstyle:
>> > NewLineAtEndOfFile
>> > > >>
>> > > >> It seems that this rule in Windows is using the wrong character to
>> > check
>> > > >> if
>> > > >> there is a new line at the end of a file.
>> > > >>
>> > > >> To solve this issue I've tried to remove the rule and use a regular
>> > > >> expression instead.
>> > > >> The problem is that I don't have Windows or a Mac to test it.
>> > > >>
>> > > >> Is there anyone that could check the pull request on WIndows and/or
>> > Mac?
>> > > >>
>> > > >> The link to the pull request is
>> > > >> https://github.com/hibernate/hibernate-ogm/pull/183
>> > > >>
>> > > >> Thanks,
>> > > >> Davide
>> > > >> _______________________________________________
>> > > >> hibernate-dev mailing list
>> > > >> hibernate-dev at lists.jboss.org
>> > > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> > > >>
>> > > >
>> > > >
>> > > _______________________________________________
>> > > hibernate-dev mailing list
>> > > hibernate-dev at lists.jboss.org
>> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> >
>> >
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>
>