[hibernate-dev] 5.2 or 6.0
Steve Ebersole
steve at hibernate.org
Fri Jun 10 15:27:20 EDT 2016
https://github.com/hibernate/hibernate-orm/pull/1411
is the minimalist change I want to do.
On Fri, Jun 10, 2016 at 12:36 AM Gunnar Morling <gunnar at hibernate.org>
wrote:
> > Does the HQL to native query mechanic use this too?
>
> Indirectly. It's used for converting query parameters, if that helps.
>
> 2016-06-08 9:31 GMT+02:00 Emmanuel Bernard <emmanuel at hibernate.org>:
>
> > Does the HQL to native query mechanic use this too?
> >
> > > On 08 Jun 2016, at 08:50, Gunnar Morling <gunnar at hibernate.org> wrote:
> > >
> > > JavaTypeDescriptorRegistry is used by Hibernate OGM in
> > > (o.h.o.type.impl.TypeTranslatorImpl).
> > >
> > >> From my side, the proposed change is good, esp. if it fixes some
> > existing
> > > bugs. It'd lock down OGM to a specific minor of ORM, but that'll happen
> > > anyways once we make use of the changes around schema tooling done in
> ORM
> > > 5.1.
> > >
> > > --Gunnar
> > >
> > >
> > > 2016-06-07 19:49 GMT+02:00 Steve Ebersole <steve at hibernate.org>:
> > >
> > >> Currently we are still working on 6.0 "on top" of 5.2, meaning that
> all
> > of
> > >> the changes we are proposing to ORM for 6.0 are kept in a separate
> > >> repo/project using ORM 5.2 as a dependency.
> > >>
> > >> As I work on 6.0 I have come across a change that I would like to make
> > that
> > >> requires that I change something in ORM proper. The specific change
> is
> > >> that I would like to remove static access
> > >> to org.hibernate.type.descriptor.sql.SqlTypeDescriptorRegistry
> > >> and org.hibernate.type.descriptor.java.JavaTypeDescriptorRegistry and
> > have
> > >> these scoped as part of the SessionFactory instead (technically as
> part
> > of
> > >> the org.hibernate.metamodel.internal.MetamodelImpl associated with a
> > >> SessionFactory).
> > >>
> > >> There are 2 ways I can go about this:
> > >>
> > >> 1. branch 5.2 and start 6.0 dev on master
> > >> 2. make this change in master for inclusion in both 5.2 and 6.0
> > >>
> > >> (2) is certainly the more convenient approach. But even beyond
> > convenient,
> > >> I have seen some bugs from the fact that these are statically typed -
> > >> theoretically they should be scoped to the SF since the SF can mutate
> > them.
> > >>
> > >> However making that change in 5.2 has some risks depending upon
> whether
> > >> apps/integrations use it. Anyone aware of any integration(s)
> accessing
> > >> these 2 registries?
> > >> _______________________________________________
> > >> hibernate-dev mailing list
> > >> hibernate-dev at lists.jboss.org
> > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > >>
> > > _______________________________________________
> > > hibernate-dev mailing list
> > > hibernate-dev at lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> >
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
More information about the hibernate-dev
mailing list