[hibernate-dev] HHH-11089

[Petar Tahchiev]

Hey guys,

a while ago I opened this issue:

https://hibernate.atlassian.net/browse/HHH-11089

which blocks me from using Hibernate with Oracle database (the well-known
issue with 30 chars limit for table/column/foreignkey/indexkey names).
While I managed to workaround the tablename/columnname by specifying a
custom PhysicalNamingStrategy. I also created a custom
ImplicitNamingStrategy, but figured out it is never invoked when I have
already specified a name for the foreign-key/indexkey. It is only called
when no name has been given for the foreign key or index. I made a pull
request, and you guys asked for some improvements.

Long-story-short I just committed my improvements:

https://github.com/hibernate/hibernate-orm/pull/1564/commits/78edc44143e39b19668099ea57e9ccb1a3a02b13

to make sure that the implicit naming strategy is always invoked no matter
if the user has specified a name for the foreign key or have omitted it.
Can someone please review it?

BTW I'm not able to build the 5.1 branch and my branch too because I get
thousands of checkstyle violations in files that I haven't worked on. I
also tried to exclude the checkstyle plugin but seems like my gradle
knowledge wasn't enough.

Thank you and keep up the good work :)

-- 
Regards, Petar!
Karlovo, Bulgaria.
---
Public PGP Key at:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x19658550C3110611
Key Fingerprint: A369 A7EE 61BC 93A3 CDFF  55A5 1965 8550 C311 0611