[hibernate-dev] Which branch to target?

Mark Rotteveel mark at lawinegevaar.nl
Sat Jun 29 08:49:04 EDT 2019

On 21-6-2019 17:09, Mark Rotteveel wrote:
> On 2019-06-19 12:12, Sanne Grinovero wrote:
>> As far as I know branch wip/6.0 is a bit in flux ATM, so it might be
>> safer to just target master.
>> Or send them to both if that's easy for you?
> I can probably do that as well.

I have my dialect changes for master ready and will open the pull 
request shortly.

I also started on a branch with the dialects for wip/6.0 but I'm running 
into all kinds of issues with query generation. Some examples:

- deletes are generated as `delete <tablename>` instead of `delete from 
<tablename>` (SQL standard syntax requires `from`, as does Firebird). 
This happens in SqlDeleteToJdbcDeleteConverter.processDeleteStatement

- joins add parentheses around table + alias elements (eg `inner join 
(<tablename> as <alias) on ...` (if I follow the rules of 7.10 <joined 
table> in SQL:2016 correctly, parentheses around table + alias are not 
in the standard grammar, nor is it allowed by Firebird). This seems to 
happen in AbstractSqlAstWalker.visitTableGroupJoin.

I could create a pull request for my current state on wip/6.0 and update 
it later, but I wonder if it would be better to wait until wip/6.0 is in 
a better state. What do you think?

Mark Rotteveel

More information about the hibernate-dev mailing list