[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-250) In ReaderStrategies, ensure that the reader is current AND that the directory returned by the DirectoryProvider are the same

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31618#action_31618 ] 

Emmanuel Bernard commented on HSEARCH-250:
------------------------------------------

I had a quick look
I am concerned by the synchronized method and the fact hat the Map is now mutable.
Wasn't it possible to test oldDirectory == currentDirectory right before calling (keeping the "oldDirectory" in ReaderUsagePair)
  if ==, use the current algo
  if !=, force to call readerFactory, keep the old ReaderUsage pair around and dicrease its usage by one

?

Try and have a chat with Sanne, he understands this part of the code very well.

> In ReaderStrategies, ensure that the reader is current AND that the directory returned by the DirectoryProvider are the same
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HSEARCH-250
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-250
>             Project: Hibernate Search
>          Issue Type: Bug
>    Affects Versions: 3.1.0.Beta1
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>            Priority: Critical
>             Fix For: 3.1.0.CR1
>
>
> When using the cluster mode, s slave has an active copy (current) and a passive copy of a Directory.
> In ReaderStrategy, we ensure the IndexReader is current but we do not ensure the Directory is the active one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira