[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-250) In ReaderStrategies, ensure that the reader is current AND that the directory returned by the DirectoryProvider are the same

[Hardy Ferentschik (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31619#action_31619 ] 

Hardy Ferentschik commented on HSEARCH-250:
-------------------------------------------

I am not to worried about the synchronized method in this case. I think it provides the right semantics and the performance should not be impacted since this method will only be called in the case where the directory provider has more than one underlying directory (eg FSSlaveDirectoryProvider) and then it will only be called once per newly 'discovered' directory. I am also not so happy about the currentReaders map. I don't mind that it is mutuable, but it should be private so that modifications to this map can only be made in the synchronized method.
AFAICS the only reason to make the map protected is to be able to test the functionality easier. There is really no need to expose the map, but I will talk to Sanne about it and see what he says. I am sure that the problem could also be solved differently, but the current apporach seemed quite straight forward.

> In ReaderStrategies, ensure that the reader is current AND that the directory returned by the DirectoryProvider are the same
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HSEARCH-250
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-250
>             Project: Hibernate Search
>          Issue Type: Bug
>    Affects Versions: 3.1.0.Beta1
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>            Priority: Critical
>             Fix For: 3.1.0.CR1
>
>
> When using the cluster mode, s slave has an active copy (current) and a passive copy of a Directory.
> In ReaderStrategy, we ensure the IndexReader is current but we do not ensure the Directory is the active one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira