[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[Hardy Ferentschik (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31780#action_31780 ] 

Hardy Ferentschik commented on HSEARCH-285:
-------------------------------------------

Actually i was hoping to move the DocumentBuilder.CLASS_FIELDNAME into ProjectionConstants in order to make the classname projectable. I believe there is a issue for that.
But if we have to really keep it what do you suggest? Should be we introduce yet another base class or interface called DocumentBuilder for DocumentBuilderContainedEntity and DocumentBuilderIndexedEntity?

> Refactor DocumentBuilder to support containedIn only and regular Indexed entities
> ---------------------------------------------------------------------------------
>
>                 Key: HSEARCH-285
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285
>             Project: Hibernate Search
>          Issue Type: Improvement
>          Components: engine
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>             Fix For: 3.1.0
>
>
> Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs).
> class ContainableEntityBuilder
> class IndexedEntityBuilder extends ContainableEntityBuilder
> (names to be refined)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira