[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31781#action_31781 ] 

Emmanuel Bernard commented on HSEARCH-285:
------------------------------------------

Hummmmm
I guess it makes more sense to put this constant onto ProjectionConstants.OBJECT_CLASS

It is slightly different semantically than the other constants, This is not a logical placeholder but the actual value used for the field name. This constant can be sued in plain Lucene query (contrary to the other ones).

In any case, we need to reintroduce a DocumentBuilder interface with the constant on it and mark that as deprecated. This is a public API, we can't mess too much with it.

> Refactor DocumentBuilder to support containedIn only and regular Indexed entities
> ---------------------------------------------------------------------------------
>
>                 Key: HSEARCH-285
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285
>             Project: Hibernate Search
>          Issue Type: Improvement
>          Components: engine
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>             Fix For: 3.1.0
>
>
> Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs).
> class ContainableEntityBuilder
> class IndexedEntityBuilder extends ContainableEntityBuilder
> (names to be refined)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira