[infinispan-dev] old workaround in CacheImpl

[Adrian Nistor]

Will remove it then.

Thanks!

On 03/13/2013 02:46 PM, Manik Surtani wrote:
> Correct answer, Dan.
>
> And yes, it can now be removed.
>
> On 12 Mar 2013, at 13:52, Dan Berindei <dan.berindei at gmail.com 
> <mailto:dan.berindei at gmail.com>> wrote:
>
>> I think the field was needed because InboundInvocationHandlerImpl was 
>> using ComponentRegistry.getComponent(ResponseGenerator.class), and 
>> there wasn't anyone actually creating the ResponseGenerator component.
>>
>> Since https://issues.jboss.org/browse/ISPN-1793, ComponentRegistry 
>> creates the ResponseGenerator component explicitly, so the field in 
>> CacheImpl is no longer needed.
>>
>>
>>
>> On Tue, Mar 12, 2013 at 1:53 PM, Mircea Markus <mmarkus at redhat.com 
>> <mailto:mmarkus at redhat.com>> wrote:
>>
>>     git annotate points to Mr. Surtani :-)
>>
>>     On 12 Mar 2013, at 11:43, Adrian Nistor wrote:
>>
>>     > And this is how it looked in 5.1.x
>>     >
>>     https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139
>>     >
>>     > On 03/12/2013 01:40 PM, Adrian Nistor wrote:
>>     >> Hi,
>>     >>
>>     >> does anyone know what issue is the unused (but injected)
>>     >> CacheImpl.responseGenerator field supposed to cure? See here:
>>     >>
>>     https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139
>>     >>
>>     >>
>>     >> The accompanying comment does not seem to be valid anymore.
>>     There is no
>>     >> jira for it and the tests run fine without it. Can't we just
>>     remove it?
>>     >>
>>     >> Cheers
>>     >> _______________________________________________
>>     >> infinispan-dev mailing list
>>     >> infinispan-dev at lists.jboss.org
>>     <mailto:infinispan-dev at lists.jboss.org>
>>     >> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>     >
>>     > _______________________________________________
>>     > infinispan-dev mailing list
>>     > infinispan-dev at lists.jboss.org
>>     <mailto:infinispan-dev at lists.jboss.org>
>>     > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>
>>     Cheers,
>>     --
>>     Mircea Markus
>>     Infinispan lead (www.infinispan.org <http://www.infinispan.org/>)
>>
>>
>>
>>
>>
>>     _______________________________________________
>>     infinispan-dev mailing list
>>     infinispan-dev at lists.jboss.org
>>     <mailto:infinispan-dev at lists.jboss.org>
>>     https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>
>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org <mailto:infinispan-dev at lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> --
> Manik Surtani
> manik at jboss.org <mailto:manik at jboss.org>
> twitter.com/maniksurtani <http://twitter.com/maniksurtani>
>
> Platform Architect, JBoss Data Grid
> http://red.ht/data-grid
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20130313/5443ad8d/attachment-0001.html