[infinispan-dev] To squash or not to squash

Mircea Markus mmarkus at redhat.com
Fri Sep 6 08:05:13 EDT 2013


When issuing pull requests people split the added functionality corresponding to a single JIRA issue into multiple logically related commits. (If they don't they should as this makes reviewer's life much easier). 
Do you think these commits should be squashed into a single commit before integrating (1) or should be integrated as such (2)?
Note that for (2), especially for very large features, internediate commits might not compile/pass the suite.

My preference is for (2) as this way the history reflects the flow of developement and makes history easier to read. 

Cheers,
Mircea


More information about the infinispan-dev mailing list