[infinispan-dev] Infinispan 7.1 plan

[Dan Berindei]

On Tue, Oct 21, 2014 at 11:59 AM, Sebastian Łaskawiec <slaskawi at redhat.com>
wrote:

> I think we can work on this one...
>
> First of all - contributors need to know about this rule, perhaps
> updating [1] might be a good idea. Official announcement on mailing list
> might be also helpful (this email thread is already pretty long, so it
> might be missed by many folks).
>

Like Sanne said, we did decide to go for a green test suite a great many
times on this list, so I don't think lack of awareness is an issue.

In fact, I was volunteered to monitor the TeamCity test results and create
a blocker issue for each failing test some time ago, but finding the proper
owner for bugs proved to be quite time consuming so I haven't been sticking
to it. This thread did motivate me to create a few new blocker issues,
however :)


>
> Secondly - we need to stop integrating Pull Requests with new failures.
> It's a bit harder when we have some existing failures, because there is
> always an excuse (this failure is not related, it's just an unstable
> test etc). But once we have clean build - it's a "binary" decision.
> I think we might also add some descriptive comment to Pull Request when
> the build is unstable - something like "This Pull Request won't be
> integrated, because it's unstable. Fix it first.".
>

Of course, the question is how we are going to achieve that magical clean
build status...

At one point we moved the random failing tests to the unstable
group/category to remove them from the main build, but I've noticed that
we've never really brought back an unstable test, at least in the core, so
I've stopped doing it. I figured having the test failures in every email
from TeamCity would motivate people to look into those failures, but I'm
not sure anyone reads the build failure emails from TeamCity :)

And it's not enough to have one master build with 0 failures. We had that
before, and it didn't really help. We have to have at least a week with 0
failures on master (with JDK7, with JDK8, and with TRACE enabled, on the
slow EC2 agent, on the fast OpenStack agents etc.) before we can say the
build is really clean.

I'm not saying we can't do it, but I share Sanne's pessimism: this time is
not that different from the last time we committed to a clean build.


>
> [1] http://infinispan.org/docs/7.0.x/contributing/contributing.html
>
> On 10/21/2014 10:27 AM, Sanne Grinovero wrote:
> > I totally agree here, but it never worked: people regularly ignore
> > failing tests, for various reasons.
> > We've had similar good intentions expressed many times, but I simply
> > have no reason to believe that this time it's going to work out.
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20141021/0d3c859a/attachment-0001.html