[infinispan-issues] [JBoss JIRA] Commented: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed

[Galder Zamarreño (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579786#comment-12579786 ] 

Galder Zamarreño commented on ISPN-913:
---------------------------------------

PurgeExpired also needs looking into. org.infinispan.loaders.modifications.PurgeExpired is no longer in use, and so the case statements for PURGE_EXPIRED are not used any more, since PurgeExpired is never created anywhere in the production code. Since AsyncStore does not override purgeExpired(), this means that purging is directly directed to the underlying cache store.


> Cache store modification types Prepare and Commit and related classes should be removed
> ---------------------------------------------------------------------------------------
>
>                 Key: ISPN-913
>                 URL: https://issues.jboss.org/browse/ISPN-913
>             Project: Infinispan
>          Issue Type: Task
>          Components: Loaders and Stores
>            Reporter: Galder Zamarreño
>            Assignee: Sanne Grinovero
>             Fix For: 4.2.1.Final, 5.0.0.ALPHA3, 5.0.0.Final
>
>
> What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for anything, including their correspondent org.infinispan.loaders.modifications.Prepare and org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we should get rid of them directly.
> It appears that since Sanne added ModificationList as type of modification in 4.1 (ISPN-618), Prepare/Commit are no longer in use.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira