[infinispan-issues] [JBoss JIRA] Commented: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed

[Sanne Grinovero (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579823#comment-12579823 ] 

Sanne Grinovero commented on ISPN-913:
--------------------------------------

??Since AsyncStore does not override purgeExpired(), this means that purging is directly directed to the underlying cache store.??
I believe that was a conscious design choice, to avoid wasting resources and such. You think I should make that async?


> Cache store modification types Prepare and Commit and related classes should be removed
> ---------------------------------------------------------------------------------------
>
>                 Key: ISPN-913
>                 URL: https://issues.jboss.org/browse/ISPN-913
>             Project: Infinispan
>          Issue Type: Task
>          Components: Loaders and Stores
>            Reporter: Galder Zamarreño
>            Assignee: Sanne Grinovero
>             Fix For: 4.2.1.Final, 5.0.0.ALPHA3, 5.0.0.Final
>
>
> What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for anything, including their correspondent org.infinispan.loaders.modifications.Prepare and org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we should get rid of them directly.
> It appears that since Sanne added ModificationList as type of modification in 4.1 (ISPN-618), Prepare/Commit are no longer in use.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira