[jboss-cvs] JBossAS SVN: r68088 - in trunk/testsuite/src/main/org/jboss/test/jca: test and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: anil.saldhana at jboss.com
Date: 2007-12-09 23:35:56 -0500 (Sun, 09 Dec 2007)
New Revision: 68088

Modified:
   trunk/testsuite/src/main/org/jboss/test/jca/fs/FSMangedConnectionFactory.java
   trunk/testsuite/src/main/org/jboss/test/jca/test/SecurityContextUnitTestCase.java
Log:
add a null subject check on FSManagedConnectionFactory

Modified: trunk/testsuite/src/main/org/jboss/test/jca/fs/FSMangedConnectionFactory.java
===================================================================
--- trunk/testsuite/src/main/org/jboss/test/jca/fs/FSMangedConnectionFactory.java	2007-12-10 04:01:44 UTC (rev 68087)
+++ trunk/testsuite/src/main/org/jboss/test/jca/fs/FSMangedConnectionFactory.java	2007-12-10 04:35:56 UTC (rev 68088)
@@ -152,6 +152,8 @@
    private void validateRoles(Subject theSubject)
       throws ResourceException
    {
+      if(theSubject == null)
+         throw new IllegalArgumentException("theSubject is null");
       Set subjectGroups = theSubject.getPrincipals(Group.class);
       Iterator iter = subjectGroups.iterator();
       Group roleGrp = null;

Modified: trunk/testsuite/src/main/org/jboss/test/jca/test/SecurityContextUnitTestCase.java
===================================================================
--- trunk/testsuite/src/main/org/jboss/test/jca/test/SecurityContextUnitTestCase.java	2007-12-10 04:01:44 UTC (rev 68087)
+++ trunk/testsuite/src/main/org/jboss/test/jca/test/SecurityContextUnitTestCase.java	2007-12-10 04:35:56 UTC (rev 68088)
@@ -94,8 +94,7 @@
    }
 
    public void testRunAsIdentityPropagationFS() throws Throwable
-   {
-      fail("FIXME CR1: NPE in roles");
+   { 
       InitialContext ctx = super.getInitialContext();
       LoginContext lc = login("ejbcaller", "ejbcallerpw".toCharArray());
       CallerIdentityHome home = (CallerIdentityHome) ctx.lookup("jca-test/RunAsIdentityFS");