[jboss-cvs] JBossAS SVN: r94360 - in projects/kernel/trunk/webbeans-int/src/main/resources: findbugs and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: kabir.khan at jboss.com
Date: 2009-10-05 07:38:42 -0400 (Mon, 05 Oct 2009)
New Revision: 94360

Added:
   projects/kernel/trunk/webbeans-int/src/main/resources/findbugs/
   projects/kernel/trunk/webbeans-int/src/main/resources/findbugs/exclude.xml
Log:
findbugs fixes and exclude file

Added: projects/kernel/trunk/webbeans-int/src/main/resources/findbugs/exclude.xml
===================================================================
--- projects/kernel/trunk/webbeans-int/src/main/resources/findbugs/exclude.xml	                        (rev 0)
+++ projects/kernel/trunk/webbeans-int/src/main/resources/findbugs/exclude.xml	2009-10-05 11:38:42 UTC (rev 94360)
@@ -0,0 +1,30 @@
+<FindBugsFilter>
+   <!-- hashcode comes from JBossObject/gethashCode() -->
+   <Match>
+      <Class name="org.jboss.kernel.webbeans.plugins.metadata.WebBeansDependencyMetaData"/>
+      <Method name="equals" params="java.lang.Object" returns="boolean"/>
+      <Bug pattern="HE_EQUALS_NO_HASHCODE"/>
+   </Match>
+
+   <!-- Asymmetric dependency? -->
+   <Match>
+      <Class name="org.jboss.kernel.webbeans.plugins.metadata.WebBeansDependencyMetaData"/>
+      <Method name="equals" params="java.lang.Object" returns="boolean"/>
+      <Bug pattern="EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC"/>
+   </Match>
+            
+   <!-- Exclude these non serializable field errors until it is clear if the metadata classes actually need to be serialized,
+      in which case there should be some tests testing that -->      
+   <Match>
+      <Class name="org.jboss.kernel.webbeans.plugins.metadata.WebBeansDependencyMetaData"/>
+      <Field name="context"/>
+      <Bug pattern="SE_BAD_FIELD"/>
+   </Match>
+            
+   <Match>
+      <Class name="org.jboss.kernel.webbeans.plugins.metadata.WebBeansDependencyMetaData"/>
+      <Field name="injectionPoint"/>
+      <Bug pattern="SE_BAD_FIELD"/>
+   </Match>
+            
+</FindBugsFilter>
\ No newline at end of file