[jboss-cvs] JBossAS SVN: r101223 - in projects/jboss-jca/trunk/deployers/src/main: java/org/jboss/jca/deployers/common/validator/rules/mcf and 1 other directories.

jboss-cvs-commits at lists.jboss.org jboss-cvs-commits at lists.jboss.org
Sun Feb 21 22:54:54 EST 2010


Author: jeff.zhang
Date: 2010-02-21 22:54:54 -0500 (Sun, 21 Feb 2010)
New Revision: 101223

Added:
   projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/rules/mcf/MCFConstructor.java
Modified:
   projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/Validator.java
   projects/jboss-jca/trunk/deployers/src/main/resources/validator.properties
Log:
[JBJCA-280] add MCFConstructor rule

Modified: projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/Validator.java
===================================================================
--- projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/Validator.java	2010-02-22 03:45:19 UTC (rev 101222)
+++ projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/Validator.java	2010-02-22 03:54:54 UTC (rev 101223)
@@ -40,6 +40,7 @@
     */
    private static final String[] CLASS_RULES = {
       "org.jboss.jca.deployers.common.validator.rules.mcf.MCF",
+      "org.jboss.jca.deployers.common.validator.rules.mcf.MCFConstructor",
       "org.jboss.jca.deployers.common.validator.rules.mcf.MCFHashCode",
       "org.jboss.jca.deployers.common.validator.rules.mcf.MCFEquals",
       "org.jboss.jca.deployers.common.validator.rules.mcf.MCFConfigProperties",

Added: projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/rules/mcf/MCFConstructor.java
===================================================================
--- projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/rules/mcf/MCFConstructor.java	                        (rev 0)
+++ projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/common/validator/rules/mcf/MCFConstructor.java	2010-02-22 03:54:54 UTC (rev 101223)
@@ -0,0 +1,86 @@
+/*
+ * JBoss, Home of Professional Open Source.
+ * Copyright 2008-2010, Red Hat Middleware LLC, and individual contributors
+ * as indicated by the @author tags. See the copyright.txt file in the
+ * distribution for a full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+
+package org.jboss.jca.deployers.common.validator.rules.mcf;
+
+import org.jboss.jca.deployers.common.validator.Failure;
+import org.jboss.jca.deployers.common.validator.Key;
+import org.jboss.jca.deployers.common.validator.Rule;
+import org.jboss.jca.deployers.common.validator.Severity;
+import org.jboss.jca.deployers.common.validator.Validate;
+
+import java.lang.reflect.Constructor;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ResourceBundle;
+
+/**
+ * A ManagedConnectionFactory must have a default constructor
+ * 
+ * @author Jeff Zhang</a>
+ * @version $Revision: $
+ */
+public class MCFConstructor implements Rule
+{
+   /** Section */
+   private static final String SECTION = "19.3";
+
+   /**
+    * Constructor
+    */
+   public MCFConstructor()
+   {
+   }
+   
+   /**
+    * Validate
+    * @param vo The validate object
+    * @param rb The resource bundle 
+    * @return The list of failures found; <code>null</code> if none
+    */
+   @SuppressWarnings("unchecked")
+   public List<Failure> validate(Validate vo, ResourceBundle rb)
+   {
+      if (vo != null && 
+          Key.MANAGED_CONNECTION_FACTORY == vo.getKey() &&
+          vo.getClazz() != null)
+      {
+         try
+         {
+            Constructor constructor = vo.getClazz().getConstructor(null);
+         }
+         catch (Throwable t)
+         {
+            List<Failure> failures = new ArrayList<Failure>(1);
+
+            Failure failure = new Failure(Severity.ERROR,
+                                          SECTION,
+                                          rb.getString("mcf.MCFConstructor"));
+            failures.add(failure);
+
+            return failures;
+         }
+      }
+
+      return null;
+   }
+}

Modified: projects/jboss-jca/trunk/deployers/src/main/resources/validator.properties
===================================================================
--- projects/jboss-jca/trunk/deployers/src/main/resources/validator.properties	2010-02-22 03:45:19 UTC (rev 101222)
+++ projects/jboss-jca/trunk/deployers/src/main/resources/validator.properties	2010-02-22 03:54:54 UTC (rev 101223)
@@ -7,6 +7,7 @@
 uncategorized=Uncategorized
 mcf.cnfe=ClassNotFoundException during ManagedConnectionFactory creation
 mcf.MCF=The class must implement the javax.resource.spi.ManagedConnectionFactory interface.
+mcf.MCFConstructor=A ManagedConnectionFactory must have a default constructor
 mcf.MCFHashCode=A ManagedConnectionFactory must implement a "public int hashCode()" method.
 mcf.MCFEquals=A ManagedConnectionFactory must implement a "public boolean equals(Object)" method.
 mcf.MCFConfigProperties=Invalid config-property-type for ManagedConnectionFactory.




More information about the jboss-cvs-commits mailing list