[jboss-dev-forums] [Design of POJO Server] - property values in ManagementViewImpl.applyTemplate

[alex.loubyansky@jboss.com]

The following part in ManagementViewImpl looks strange to me.
What is the logic with serializable?
The componentName for connection factories is always null. Even if it wasn't, they wouldn't be registered to the kernel, would they? Or I missing the part where they are registered?

Thanks!

   public void applyTemplate(DeploymentPhase phase, String deploymentBaseName, DeploymentTemplateInfo info)
  | ...
  |          // TODO - decide what is the type of value when we set it
  |          // since currently get always returns MetaValue, but we see some cases
  |          // where plain Serializable is enough
  |          Serializable serializable;
  |          MetaValue metaValue;
  |          Object value = prop.getValue();
  |          if (value instanceof MetaValue)
  |          {
  |             metaValue = (MetaValue)value;
  |             MetaType metaType = metaValue.getMetaType();
  |             if (metaType.isSimple())
  |                serializable = ((SimpleValue)metaValue).getValue();
  |             else if (metaType.isGeneric())
  |                serializable = ((GenericValue)metaValue).getValue();
  |             else
  |                serializable = null;
  |          }
  |          else
  |          {
  |             serializable = (Serializable)value;
  |             metaValue = metaValueFactory.create(value);
  |          }
  | // I add this check for the tests to pass         if(serializable != null)
  |          ctxProp.setValue(serializable);
  |          // todo - should this also dispatch to runtime component?
  |          Object componentName = getComponentName(ctxProp);
  |          if("xa-datasource-properties".equals(ctxProp.getName()))
  |             System.out.println("componentName for prop=" + ctxProp.getName() + ": " + componentName + " " + ctxProp.getManagedObject());
  |          if (componentName != null)
  |             dispatcher.set(componentName, ctxProp.getName(), metaValue);
  |       }
  |    }
  | 

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4114513#4114513

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4114513