[jboss-dev-forums] [Design of EJB 3.0] - Re: EJBTHREE-1396 MockServer must report startup / shutdown

[jaikiran]

Thanks everyone for your time and the comments. 

"ALRubinger" wrote : * Constants like SERVER_STARTING should be marked "final"? 

Agreed. That was my silly mistake.

"ALRubinger" wrote : 
  | * MockServerMonitor has hardcoded "localhost" used by the ServerSocket. If we've gotta specify a port, might as well specify a host bind address (to bind to 2 unique hosts using same port for example)
  | 

Sure, will change it to allow the host bind address to be a parameter.

I'll consider the rest of the comments too:

- Not good OO pratice
- Chances of the test case waiting indefinitely
- The static instance of MockServer in itself.

Thanks again, for the inputs :)




View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4187213#4187213

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4187213