[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: new QueueBrowser implementation

[ataylor]

anonymous wrote : Looking at your latest commit, I notice you added a method on the public client session api "createQueueCopy" - why is this necessary?
  | 
  | Whilst, as a temporary measure the queue needs to be copied before browsing, there is no need for this to be exposed on the client or the wireformat, this should just be an internal implementation detail, when creating the browser on the server. 

Ok I'll change this.

anonymous wrote : 1) The copy queue was being created using the createQueue method which would also bind it in the post office. This is unnecessary - all we want is a simple in memory copy we can browse 

This is so any new messages routed to that address are received by the browser. If we're only bothered about whats in a queue at a certain point in time then We don't need to do it.



anonymous wrote : 2) The queueCopyLock was unnecessary - the list() method on Queue is already synchronized. 

Again, this was so no new messages were delivered to the queue after the list method was called.



anonymous wrote : We also need some core integration tests that test the new browsing implementation. 

I'm in the process of writing these.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4183138#4183138

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4183138