[jboss-dev-forums] [JBoss AS7 Development] - JCA / Datasources in domain.xml

[Stefano Maestri]

Stefano Maestri [http://community.jboss.org/people/maeste] replied to the discussion

"JCA / Datasources in domain.xml"

To view the discussion, visit: http://community.jboss.org/message/557500#557500

--------------------------------------------------------------
> Jesper Pedersen wrote:
> 
> Looks good. A couple of comments
> I think we should remove the -settings suffix - f.ex. 'validation-settings' -> 'validation'.
Done in my last commit, with changes to metadatas interfaces and implementation according.
In this commit I've also changed a bit xsd to adhere xsd name comnvention of AS7 (mainly *Type for type definition instead of *ComplexType or *Value I've used before for complex and simple types) as I discussed in IRC with David.

> Jesper Pedersen wrote:
> 
> Also we need a way to pass in configuration properties and their values to the user supplied classes like the validation connection checker and the exception sorter to allow user to override default values in the implementation. F.ex. overriding the timeout value for the database ping method:
> 
> <valid-connection-checker>
> 
> <class-name>com.mycompany.MyConnectionChecker</class-name>
> 
>   <property name="Timeout">1</property>
> </valid-connection-checker>
> 
> 
> 
> 
And what about making class name an attribute? It wpuld results in a more compact xml in case of no property, and an easier to read one in case of multiple config property:


<valid-connection-checker class-name="com.mycompany.MyConnectionChecker" />


<valid-connection-checker class-name="com.mycompany.MyConnectionChecker">
     <property name="Timeout">1</property>
     <property name="OtherProperty">2</property>

</valid-connection-checker>






> Jesper Pedersen wrote:
> 
> However, that can come later (post M1), as we need to enhance the JDBC resource adapter with this feature too.
Well, if we can agree at least on the xsd structure I'd prefer to change xsd now, to limit (as much as possible) changes in metadatas api.

best regards
S.

--------------------------------------------------------------

Reply to this message by going to Community
[http://community.jboss.org/message/557500#557500]

Start a new discussion in JBoss AS7 Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2225]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jboss-dev-forums/attachments/20100816/943c2e96/attachment.html