[jboss-dev] Re: Commons-logging upgrade

[Scott M Stark]

Assign it to me and I'll look at what the trade offs are.

Dimitris Andreadis wrote:
> I had a quick look at cvs.forge.jboss.com:/cvsroot/jboss -
> apache/commons-logging.
> 
> If we are going to patch the latest v1.1, I'd rather let Scott do it,
> since he has been maintaining the patched library from the start.
> 
> On the other hand, wouldn't the right thing to do be for users to have
> to include commons-logging.jar + log4j.jar, even if that means older
> deployments might be slightly broken (but easy to fix)?
> 
>> -----Original Message-----
>> From: Brian Stansberry 
>> Sent: Wednesday, January 24, 2007 7:32 PM
>> To: Dimitris Andreadis; Scott M Stark
>> Cc: 'JBoss.org development list'
>> Subject: RE: [jboss-dev] Re: Commons-logging upgrade
>>
>> So, 2 issues:
>>
>> 1) Do we remove org.apache.commons.logging from FilteredPackages?
>>
>> I've attached 2 files showing what happens if you do this in 
>> 4.0.5 and 4.0.2 and then deploy a war with 
>> commons-logging.jar included.  The 4.0.2 one shows a 
>> JaccContextValve failure that was likely the thing that led 
>> to filtering the packages.
>>
>> In 4.2, this works fine.
>>
>> IMHO, if a quick perusal of the attached files by you and 
>> Scott isn't enough to decide to remove the filtering of JCL 
>> packages, we should leave them filtered. That's a 
>> conservative approach, which is fine when we have lots of 
>> other things to worry about.
>>
>> 2) Patching JCL 1.1 to do late binding of log4j.  That's 
>> useful, if for nothing else to support consistent behavior 
>> from 4.0.x to 4.2.0 for wars that bundle log4j but not 
>> commons-logging.jar. Definitely needed if we decide to keep 
>> the jcl package filtering. The JIRA to do the patch was 
>> assigned by you to you, so I guess you volunteered ;)
>>
>> You're my boss, so feel free to assign it to me. :-) But I 
>> won't touch it until the EJB3 stuff and shared sessions are done.