[jboss-jira] [JBoss JIRA] Commented: (JGRP-850) Fix output leak in testNG test reporting

[Richard Achmatowicz (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12435811#action_12435811 ] 

Richard Achmatowicz commented on JGRP-850:
------------------------------------------

I forgot one thing. I downloaded the 5.8.1 source from the testng Google source repo (which is what Vladimir seems to have done to replace the jar) but this code seems to have a bug in it, in that the IInvokedMethodListener inteface callbacks do not get called. I fixed the bug (a simple callback registration check was left out for that listener in testNG.java) and used that jar, not Vladimir's changed jar, to test my stuff. I rembered this when I was getting ready to commit my changes earlier today and the stuff didn't work with the untouched 5.8.1 jar.

So, maybe to be safe, i'll post a note on the testng forum and get confirmation from C. Beust that the change I made is required and get him to update the source, then add in my change and the updated library.  It may be that he had a different approach to registering the interface callbacks which i'm not aware of.

I'll confirm when I hear from him. 

> Fix output leak in testNG test reporting
> ----------------------------------------
>
>                 Key: JGRP-850
>                 URL: https://jira.jboss.org/jira/browse/JGRP-850
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Richard Achmatowicz
>            Assignee: Richard Achmatowicz
>            Priority: Minor
>             Fix For: 2.7
>
>
> org.jgroups.util.JUnitXmlReporter is a class which takes output from testNG test cases and prepares xml test case reports in JUnit-compatible format. These xml files are then used to generate JUnit style reports.
> At present, output from test case methods which execute before the main test case (testNG configurator methods, such as @BeforeSuite, @AfterSite, etc) written to System.out and System.err is leaking to the console and not being captured with the rest of the testNG output. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira