[jboss-jira] [JBoss JIRA] Commented: (JGRP-850) Fix output leak in testNG test reporting

[Richard Achmatowicz (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12436487#action_12436487 ] 

Richard Achmatowicz commented on JGRP-850:
------------------------------------------

It's been four days since posting on testng-users and still no reply on whether or not the registration for IINvokkedMethodListener is broken or not.
I'll wait a few days more. For you information, here is the fix I made to the testNG 5.8.1 source file testNG.java:


  public void addListener(Object listener) {
    if (! (listener instanceof ITestNGListener))
    {
      exitWithError("Listener " + listener
          + " must be one of ITestListener, ISuiteListener, IReporter,
          + " IAnnotationTransformer, IMethodInterceptor or IInvokedMethodListener");
    }
    else {
      if (listener instanceof ISuiteListener) {
        addListener((ISuiteListener) listener);
      }
      if (listener instanceof ITestListener) {
        addListener((ITestListener) listener);
      }
      if (listener instanceof IReporter) {
        addListener((IReporter) listener);
      }
      if (listener instanceof IAnnotationTransformer) {
        setAnnotationTransformer((IAnnotationTransformer) listener);
      }
      if (listener instanceof IMethodInterceptor) {
        m_methodInterceptor = (IMethodInterceptor) listener;
      }
 
     // added code to register the IInvokedMethodListener
     if (listener instanceof IInvokedMethodListener) {
        addListener((IInvokedMethodListener) listener ;
     }
     // end of added code

    }
  }



> Fix output leak in testNG test reporting
> ----------------------------------------
>
>                 Key: JGRP-850
>                 URL: https://jira.jboss.org/jira/browse/JGRP-850
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Richard Achmatowicz
>            Assignee: Richard Achmatowicz
>            Priority: Minor
>             Fix For: 2.7
>
>
> org.jgroups.util.JUnitXmlReporter is a class which takes output from testNG test cases and prepares xml test case reports in JUnit-compatible format. These xml files are then used to generate JUnit style reports.
> At present, output from test case methods which execute before the main test case (testNG configurator methods, such as @BeforeSuite, @AfterSite, etc) written to System.out and System.err is leaking to the console and not being captured with the rest of the testNG output. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira