[jboss-jira] [JBoss JIRA] Assigned: (JGRP-988) Add API to manipulate JChannelFactory stacks member

[Brian Stansberry (JIRA)]

     [ https://jira.jboss.org/jira/browse/JGRP-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry reassigned JGRP-988:
-------------------------------------

    Assignee: Brian Stansberry  (was: Bela Ban)


I'd prefer to have the class in AS. The problem is JBC and JBM use the JGroups version, so the AS is forced to subclass it to be compatible.

I'll think about it a bit; if you aren't going to ever change this class I could simply move the entire impl into the AS class and almost treat the JGroups class as an interface. Save the JGroups project the hassle of making changes, putting them in releases etc.

> Add API to manipulate JChannelFactory stacks member
> ---------------------------------------------------
>
>                 Key: JGRP-988
>                 URL: https://jira.jboss.org/jira/browse/JGRP-988
>             Project: JGroups
>          Issue Type: Feature Request
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: 2.6.11
>
>
> I'd like to see the following methods added to JChannelFactory to go along with the existing getConfig and removeConfig.  These will allow the JBoss AS-specific subclass to update the contents of the "stacks" member in response to updates from management tools like the embedded console or Jopr:
> public boolean addConfig(String stack_name, String config, boolean replace) {
>    boolean added = replace;
>    if(replace) {
>        stacks.put(st_name, val);
>        if(log.isTraceEnabled())
>            log.trace("added config '" + st_name + "'");
>     }
>     else {
>         if(!stacks.containsKey(st_name)) {
>             stacks.put(st_name, val);
>             added = true;
>             if(log.isTraceEnabled())
>                log.trace("added config '" + st_name + "'");
>     }
>     else {
>          if(log.isTraceEnabled())
>            log.trace("didn't add config '" + st_name + " because one of the same name already existed");
>     }
>     return added;
> }
> public Set<String> getConfigNames() {
>    return Collections.unmodifiableSet(stacks.keySet());
> }
> Bela, I've assigned this to you to get your feedback on it, but I'd be happy to do it. Just assign back to me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira