[jboss-jira] [JBoss JIRA] Commented: (JGRP-988) Add API to manipulate JChannelFactory stacks member

[Brian Stansberry (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12471312#action_12471312 ] 

Brian Stansberry commented on JGRP-988:
---------------------------------------

Sorry; that last comment was totally off-base. JBC uses the ChannelFactory interface, not the JChannelFactory class. I have a memory of needing to subclass for some reason, but perhaps I'm wrong; maybe the AS version just started off as a minor extension that has now grown so large it shouldn't be a subclass. I'll keep poking.

> Add API to manipulate JChannelFactory stacks member
> ---------------------------------------------------
>
>                 Key: JGRP-988
>                 URL: https://jira.jboss.org/jira/browse/JGRP-988
>             Project: JGroups
>          Issue Type: Feature Request
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: 2.6.11
>
>
> I'd like to see the following methods added to JChannelFactory to go along with the existing getConfig and removeConfig.  These will allow the JBoss AS-specific subclass to update the contents of the "stacks" member in response to updates from management tools like the embedded console or Jopr:
> public boolean addConfig(String stack_name, String config, boolean replace) {
>    boolean added = replace;
>    if(replace) {
>        stacks.put(st_name, val);
>        if(log.isTraceEnabled())
>            log.trace("added config '" + st_name + "'");
>     }
>     else {
>         if(!stacks.containsKey(st_name)) {
>             stacks.put(st_name, val);
>             added = true;
>             if(log.isTraceEnabled())
>                log.trace("added config '" + st_name + "'");
>     }
>     else {
>          if(log.isTraceEnabled())
>            log.trace("didn't add config '" + st_name + " because one of the same name already existed");
>     }
>     return added;
> }
> public Set<String> getConfigNames() {
>    return Collections.unmodifiableSet(stacks.keySet());
> }
> Bela, I've assigned this to you to get your feedback on it, but I'd be happy to do it. Just assign back to me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira