[jboss-jira] [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible

Dan Allen (JIRA) jira-events at lists.jboss.org
Thu Mar 24 14:18:51 EDT 2011


    [ https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591658#comment-12591658 ] 

Dan Allen commented on JBLOGGING-52:
------------------------------------

We need a simpler, less global way of enabling the proxy generation. The simplest way for developers is likely to include a .properties file on the classpath, perhaps with a boolean property that enables or disables it. Application developers need a simple step that does not involve changing the parameters by which the application server starts (because that requires different instructions per application server that frankly we don't want to have to worry about).

> Use of system property for proxy generation setting is too inflexible
> ---------------------------------------------------------------------
>
>                 Key: JBLOGGING-52
>                 URL: https://issues.jboss.org/browse/JBLOGGING-52
>             Project: JBoss Logging
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: jboss-logging-spi
>    Affects Versions: 3.0.0.Beta4-jboss-logging
>            Reporter: Dan Allen
>            Assignee: Dan Allen
>             Fix For: 3.0.0.Beta5-jboss-logging
>
>
> JBoss Logging uses a system property to configure whether or not proxies are generated for type-safe loggers. This approach is very inflexible.
> The main issue is that the value of this system property is being cached too aggressively. In CDI extensions, we are forced to use a static code block to set the property so it is assigned early enough that JBoss Logging caches the correct value. However, with multiple extensions loading in a non-deterministic order, we end up having to put this static block in multiple places. [1]
> We need a better way to apply this setting. Perhaps a static method on a configuration API to assign the value before any logging takes place. 
> [1] https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/seam/solder/log/LoggerExtension.java
> https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/seam/servlet/ServletExtension.java 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jboss-jira mailing list