[jboss-jira] [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591663#comment-12591663 ] 

David Lloyd commented on JBLOGGING-52:
--------------------------------------

I've gotta be honest, I don't think the proxy feature should even exist.  If a developer is building a development version of their module, they're running it through a compiler.  If they're running it through a compiler then they're also running it through an annotation processor, ergo they'll have the generated classes.

The only case this doesn't hold true is for IDEs - supposedly - though as an IDE user I have yet to encounter this situation.

> Use of system property for proxy generation setting is too inflexible
> ---------------------------------------------------------------------
>
>                 Key: JBLOGGING-52
>                 URL: https://issues.jboss.org/browse/JBLOGGING-52
>             Project: JBoss Logging
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: jboss-logging-spi
>    Affects Versions: 3.0.0.Beta4-jboss-logging
>            Reporter: Dan Allen
>            Assignee: Dan Allen
>             Fix For: 3.0.0.Beta5-jboss-logging
>
>
> JBoss Logging uses a system property to configure whether or not proxies are generated for type-safe loggers. This approach is very inflexible.
> The main issue is that the value of this system property is being cached too aggressively. In CDI extensions, we are forced to use a static code block to set the property so it is assigned early enough that JBoss Logging caches the correct value. However, with multiple extensions loading in a non-deterministic order, we end up having to put this static block in multiple places. [1]
> We need a better way to apply this setting. Perhaps a static method on a configuration API to assign the value before any logging takes place. 
> [1] https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/seam/solder/log/LoggerExtension.java
> https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/seam/servlet/ServletExtension.java 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira