[jboss-jira] [JBoss JIRA] (JGRP-2138) Request.viewChange() implementations should not use View.getMembers()

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13335014#comment-13335014 ] 

Bela Ban commented on JGRP-2138:
--------------------------------

Hmm, View is already iterable. I might actually make View implement List<Address> and just support a limited number of operations (e.g. get()), and throw an UnsupportedOperationException on others, e.g. clear() or subList().

> Request.viewChange() implementations should not use View.getMembers()
> ---------------------------------------------------------------------
>
>                 Key: JGRP-2138
>                 URL: https://issues.jboss.org/browse/JGRP-2138
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Dan Berindei
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 3.6.12, 4.0
>
>
> {{Request.viewChange()}} is called once for every request, and {{View.getMembers()}} allocates 2 (small) objects. Both {{UnicastRequest}} and {{GroupRequest}} could use {{View.containsMember()}} instead.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)