[jboss-jira] [JBoss JIRA] (JGRP-2138) Request.viewChange() implementations should not use View.getMembers()

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13335019#comment-13335019 ] 

Dan Berindei commented on JGRP-2138:
------------------------------------

I don't think you really need to implement {{List<Address>}}, but if you do please keep {{getMembers()}} and return {{this}}.

For me either variation of {{getMembers()}} is fine as long as {{Request}} isn't using it. We're only calling {{getMembers()}} in Infinispan when we get a new view, same as most protocols.

> Request.viewChange() implementations should not use View.getMembers()
> ---------------------------------------------------------------------
>
>                 Key: JGRP-2138
>                 URL: https://issues.jboss.org/browse/JGRP-2138
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Dan Berindei
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 3.6.12, 4.0
>
>
> {{Request.viewChange()}} is called once for every request, and {{View.getMembers()}} allocates 2 (small) objects. Both {{UnicastRequest}} and {{GroupRequest}} could use {{View.containsMember()}} instead.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)