[jboss-jira] [JBoss JIRA] (WFLY-7462) Do not log common CLI failures for Elytron to server log

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13317692#comment-13317692 ] 

Brian Stansberry commented on WFLY-7462:
----------------------------------------

Thanks [~dlofthouse]. Perhaps that and the other issues Ondrej reports have the same underlying cause. It smells like Stage.MODEL checks are not occurring, so then things fail in Stage.RUNTIME. For example, this should only be logged in the server.log if it is caught in Stage.RUNTIME:

{code}
ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([
    ("subsystem" => "elytron"),
    ("properties-realm" => "realm")
]) - failure description: "WFLYCTL0155: path may not be null"
{code}

The fact it's logged tells me it wasn't caught in MODEL like it should have been. A capability conflict should also be caught in MODEL.

I looked at the code for the property-realm add though yesterday and didn't see anything that would have caused that.

> Do not log common CLI failures for Elytron to server log
> --------------------------------------------------------
>
>                 Key: WFLY-7462
>                 URL: https://issues.jboss.org/browse/WFLY-7462
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>    Affects Versions: 11.0.0.Alpha1
>            Reporter: Ondrej Lukas
>            Assignee: Darran Lofthouse
>            Priority: Critical
>              Labels: user_experience
>
> Almost every common CLI command failure from Elytron subsystem is logged as ERROR to server log. For example this means:
> * trying to add duplicate service -> ERROR in server log
> * missing required attribute of any resource attribute in CLI command -> ERROR in server log
> * missing capability -> ERROR in server log
> * ...
> Some reasons why these logs should not be logged to server log:
> * Adding useless messages to server log.
> * This is inconsistent with other subsystems (e.g. PicketBox). It can be confusing.
> These common CLI command failures should be removed from the log, or logged on low level (i.e. DEBUG)



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)