[jboss-jira] [JBoss JIRA] (JGRP-2125) Bits: reading ints and longs is allocating unnecessary memory

[Bela Ban (JIRA)]

     [ https://issues.jboss.org/browse/JGRP-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bela Ban resolved JGRP-2125.
----------------------------
    Resolution: Done


> Bits: reading ints and longs is allocating unnecessary memory
> -------------------------------------------------------------
>
>                 Key: JGRP-2125
>                 URL: https://issues.jboss.org/browse/JGRP-2125
>             Project: JGroups
>          Issue Type: Enhancement
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 4.0
>
>
> Some readXXX() methods in Bits such as readLong(), readInt(), readLongSequence(), readLongCompressed() etc read the length byte first, then create a byte[] array based on it, read the required bytes into that array and finally call makeInt()/makeLong() etc.
> The creation of the temp byte[] array is unnecessary and leads to unneeded memory allocation, especially as quite a number of frequently used headers (e.g. NakAckHeader2, UnicastHeader3 etc) do this.
> SOLUTION: read the required bytes directly from the input (e.g. java.nio.ByteBuffer or DataInput) and apply them to the result one-by-one, then return the result.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)