[jboss-jira] [JBoss JIRA] (WFCORE-3359) Use non-compact ModelNode.writeString to print operation failure messages on multiple lines in the log

[James Perkins (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477082#comment-13477082 ] 

James Perkins commented on WFCORE-3359:
---------------------------------------

I think it would be okay to pretty print the DMR output. We have plenty of other places where multiline messages are used. The one area of concern would be users using some kind of log collector that parses the server log. However I'm generally of the opinion that parsing log output is not a good idea. 

> Use non-compact ModelNode.writeString to print operation failure messages on multiple lines in the log
> ------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-3359
>                 URL: https://issues.jboss.org/browse/WFCORE-3359
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Minor
>
> When we log operation failures perhaps the logging would be better if we used the non-compact representation of DMR.
> We need to confirm with GSS and folks  like [~jamezp] that this is a good idea. A concern is the message has more lines, but it's often already a multi-line message.
> See also some of the discussion on JBEAP-10713.
> I think this is basically a change at:
> https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java#L982
> https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java#L1003
> https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java#L1007



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)